From 9a024bb8a17df7ba6b3e8b6dabba07d04cc405f4 Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Sun, 14 Apr 2019 08:34:13 +0100 Subject: [PATCH 1/4] Add lint script --- composer.json | 1 + 1 file changed, 1 insertion(+) diff --git a/composer.json b/composer.json index 2aecfec1f..90b0d984c 100644 --- a/composer.json +++ b/composer.json @@ -15,6 +15,7 @@ "scripts": { "dev": "composer run-script generate", "generate": "sculpin generate --clean --no-interaction", + "lint": "php-cs-fixer fix", "prod": "composer run-script generate -- --env prod", "watch": "composer run-script --timeout=0 generate -- --server --watch", "test": "phpunit" From dd714adf6a59715986a50d96169f764719f9e95a Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Sun, 14 Apr 2019 08:34:39 +0100 Subject: [PATCH 2/4] Run composer lint --- netlify.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/netlify.toml b/netlify.toml index 6d3abde51..8ea1d9958 100644 --- a/netlify.toml +++ b/netlify.toml @@ -1,5 +1,6 @@ [build] command = """ +composer lint -- --dry-run yarn lint composer test composer prod From f22daca45a12f54d5c167535c1ef2810e195484e Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Sun, 14 Apr 2019 09:18:38 +0100 Subject: [PATCH 3/4] Prevent error with require --- .eslintrc.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc.js b/.eslintrc.js index 1f5c1915d..d55a37541 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -1,7 +1,8 @@ module.exports = { 'env': { 'browser': true, - 'es6': true + 'es6': true, + "node": true }, 'extends': [ 'eslint:recommended', From 18f389e49c042b3462af89568a0a0e93716e8697 Mon Sep 17 00:00:00 2001 From: Oliver Davies Date: Sun, 14 Apr 2019 09:19:08 +0100 Subject: [PATCH 4/4] Update lint command --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index 8ea1d9958..686bde726 100644 --- a/netlify.toml +++ b/netlify.toml @@ -1,7 +1,7 @@ [build] command = """ composer lint -- --dry-run -yarn lint +yarn lint --fix-dry-run composer test composer prod yarn prod